Layered turret top rendering #2769
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6262151456.zip |
github-actions
bot
added
the
Download in Comments
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6262187508.zip |
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6626946018.zip |
N7Huntsman
approved these changes
Nov 28, 2023
|
Mothballing this, but preserving the branch. It broadly works in testing, but in the absence of someone doing the texture work for the various turret elements, it lacks a purpose. Additionally, the standard visual recoil is satisfactory--may revisit this if someone cares to create the textures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions
Render turret top in multiple layers, top base -> barrels *n -> top.
If multiple barrel is defined and the gun fires in burst, the barrels reciprocate in alternation.
Everything in a modextension, CombatExtended.TurretDrawExtension
TurretTopGraphicData: graphic data of whatever sprite above the barrels
Barrels: a list of barrels
each barrels consist of:
BarrelOffset: vector2 offset of this barrel
BarrelGraphicData: graphic data of this barrel
TurretBottomGraphicData: graphic data of whatever sprite below the barrels
Reasoning
90mm gun looks stupid with its gunshield reciprocating along with barrel.
Alternatives
Suffer.
Testing
Check tests you have performed: